Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic: runtime error on SetClaimer #238

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix panic: runtime error on SetClaimer #238

merged 1 commit into from
Nov 12, 2024

Conversation

aivarasko
Copy link
Contributor

This fixes panic using SetClaimer when unhandled GetTxFeeDetails returns nil transaction instead of returning error.

Example of before fix:

[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x1010a6d40]

goroutine 1 [running]:
github.com/ethereum/go-ethereum/core/types.(*Transaction).GasTipCap(0x0)
	/Users/aivaras/go/pkg/mod/github.com/ethereum/[email protected]/core/types/transaction.go:295 +0x30
github.com/Layr-Labs/eigenlayer-cli/pkg/internal/common.GetTxFeeDetails(0x0)
	/Users/aivaras/projects/eigenlayer-cli/pkg/internal/common/eth.go:37 +0x24
...

Fix would return more informative error like:

failed to create unsigned tx: no contract code at given address

@aivarasko
Copy link
Contributor Author

Please take a look @shrimalmadhur @gpabst

shrimalmadhur
shrimalmadhur approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@shrimalmadhur shrimalmadhur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. lgtm

@shrimalmadhur shrimalmadhur merged commit 680b434 into Layr-Labs:master Nov 12, 2024
8 checks passed
@aivarasko aivarasko deleted the fix/set-claimer-gas branch November 12, 2024 16:14
bdchatham pushed a commit to bdchatham/eigenlayer-cli that referenced this pull request Nov 13, 2024
@aivarasko
Fix panic: runtime error on SetClaimer (Layr-Labs#238)
72730db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrimalmadhur shrimalmadhur shrimalmadhur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aivarasko @shrimalmadhur